adulau/cakephp2-php8
1
0
Fork 0
mirror of https://github.com/kamilwylegala/cakephp2-php8.git synced 2025-01-31 09:06:17 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

Use safer methods to read session configuration.

Browse source 
Avoid potential undefined index warnings by using read() to safely fetch
data.

Refs #8101
This commit is contained in:
mark_story 2016-01-30 16:11:50 -05:00
parent fc57dee72f
commit d9992bcaca
1 changed files with 4 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
lib/Cake/Model/Datasource/CakeSession.php
View file

@ -345,12 +345,13 @@ class CakeSession {
* @return bool * @return bool
*/ */
protected static function _validAgentAndTime() { protected static function _validAgentAndTime() {
$config = static::read('Config'); $userAgent = static::read('Config.userAgent');
$time = static::read('Config.time');
$validAgent = ( $validAgent = (
Configure::read('Session.checkAgent') === false || Configure::read('Session.checkAgent') === false ||
isset($config['userAgent']) && static::$_userAgent === $config['userAgent'] isset($userAgent) && static::$_userAgent === $userAgent
); );
return ($validAgent && static::$time <= $config['time']); return ($validAgent && static::$time <= $time);
} }
/** /**