diff --git a/lib/Cake/Console/ConsoleOutput.php b/lib/Cake/Console/ConsoleOutput.php index fa021b565..5e1ce9bec 100644 --- a/lib/Cake/Console/ConsoleOutput.php +++ b/lib/Cake/Console/ConsoleOutput.php @@ -295,7 +295,9 @@ class ConsoleOutput { * Clean up and close handles */ public function __destruct() { - fclose($this->_output); + if (is_resource($this->_output)) { + fclose($this->_output); + } } } diff --git a/lib/Cake/Console/Templates/default/classes/controller.ctp b/lib/Cake/Console/Templates/default/classes/controller.ctp index e290a8675..3e5a3004e 100644 --- a/lib/Cake/Console/Templates/default/classes/controller.ctp +++ b/lib/Cake/Console/Templates/default/classes/controller.ctp @@ -74,7 +74,9 @@ class Controller extends App echo ");\n\n"; endif; - echo trim($actions); + if (!empty($actions)) { + echo trim($actions) . "\n"; + } endif; ?> } diff --git a/lib/Cake/Controller/Component/Acl/IniAcl.php b/lib/Cake/Controller/Component/Acl/IniAcl.php index f212938c4..0fa9fd334 100644 --- a/lib/Cake/Controller/Component/Acl/IniAcl.php +++ b/lib/Cake/Controller/Component/Acl/IniAcl.php @@ -43,7 +43,7 @@ class IniAcl extends Object implements AclInterface { /** * Initialize method * - * @param AclBase $component + * @param Component $component * @return void */ public function initialize(Component $component) { diff --git a/lib/Cake/Controller/Component/AclComponent.php b/lib/Cake/Controller/Component/AclComponent.php index 6d0f3b8b4..fc87b3c6e 100644 --- a/lib/Cake/Controller/Component/AclComponent.php +++ b/lib/Cake/Controller/Component/AclComponent.php @@ -21,8 +21,8 @@ App::uses('AclInterface', 'Controller/Component/Acl'); * Access Control List factory class. * * Uses a strategy pattern to allow custom ACL implementations to be used with the same component interface. - * You can define by changing `Configure::write('Acl.classname', 'DbAcl');` in your core.php. Concrete ACL - * implementations should extend `AclBase` and implement the methods it defines. + * You can define by changing `Configure::write('Acl.classname', 'DbAcl');` in your core.php. The adapter + * you specify must implement `AclInterface` * * @package Cake.Controller.Component * @link http://book.cakephp.org/2.0/en/core-libraries/components/access-control-lists.html diff --git a/lib/Cake/Model/Datasource/Database/Sqlserver.php b/lib/Cake/Model/Datasource/Database/Sqlserver.php index e7c202c4c..95a4801fd 100644 --- a/lib/Cake/Model/Datasource/Database/Sqlserver.php +++ b/lib/Cake/Model/Datasource/Database/Sqlserver.php @@ -767,6 +767,7 @@ class Sqlserver extends DboSource { */ protected function _execute($sql, $params = array(), $prepareOptions = array()) { $this->_lastAffected = false; + $sql = trim($sql); if (strncasecmp($sql, 'SELECT', 6) === 0 || preg_match('/^EXEC(?:UTE)?\s/mi', $sql) > 0) { $prepareOptions += array(PDO::ATTR_CURSOR => PDO::CURSOR_SCROLL); return parent::_execute($sql, $params, $prepareOptions); diff --git a/lib/Cake/Test/Case/Controller/Component/AclComponentTest.php b/lib/Cake/Test/Case/Controller/Component/AclComponentTest.php index 375d03067..66d991c4b 100644 --- a/lib/Cake/Test/Case/Controller/Component/AclComponentTest.php +++ b/lib/Cake/Test/Case/Controller/Component/AclComponentTest.php @@ -78,7 +78,7 @@ class AclComponentTest extends CakeTestCase { } /** - * test that adapter() whines when the class is not an AclBase + * test that adapter() whines when the class does not implement AclInterface * * @expectedException CakeException * @return void diff --git a/lib/Cake/Utility/Validation.php b/lib/Cake/Utility/Validation.php index 766b62820..a2d08bb65 100644 --- a/lib/Cake/Utility/Validation.php +++ b/lib/Cake/Utility/Validation.php @@ -719,8 +719,8 @@ class Validation { * $check is a legal finite on this platform * * @param string $check Value to check - * @param integer $lower Lower limit - * @param integer $upper Upper limit + * @param int|float $lower Lower limit + * @param int|float $upper Upper limit * @return boolean Success */ public static function range($check, $lower = null, $upper = null) {