From c718a182188124b47f7652f00744e26363512079 Mon Sep 17 00:00:00 2001 From: mark_story Date: Sun, 8 Apr 2012 21:01:25 -0400 Subject: [PATCH] Fix coding standards errors. --- lib/Cake/Test/Case/Console/ShellTest.php | 6 ++++-- lib/Cake/Test/Case/Controller/ControllerTest.php | 2 ++ lib/Cake/Test/Case/Network/Email/CakeEmailTest.php | 7 ++++--- 3 files changed, 10 insertions(+), 5 deletions(-) diff --git a/lib/Cake/Test/Case/Console/ShellTest.php b/lib/Cake/Test/Case/Console/ShellTest.php index 4e75b29b9..f973efd91 100644 --- a/lib/Cake/Test/Case/Console/ShellTest.php +++ b/lib/Cake/Test/Case/Console/ShellTest.php @@ -54,14 +54,16 @@ class ShellTestShell extends Shell { $this->stopped = $status; } - public function do_something() { + protected function _secret() { } - protected function _secret() { + //@codingStandardsIgnoreStart + public function do_something() { } protected function no_access() { } + //@codingStandardsIgnoreEnd public function mergeVars($properties, $class, $normalize = true) { return $this->_mergeVars($properties, $class, $normalize); diff --git a/lib/Cake/Test/Case/Controller/ControllerTest.php b/lib/Cake/Test/Case/Controller/ControllerTest.php index b2b0a1ba3..472c7a48c 100644 --- a/lib/Cake/Test/Case/Controller/ControllerTest.php +++ b/lib/Cake/Test/Case/Controller/ControllerTest.php @@ -289,6 +289,7 @@ class TestController extends ControllerTestAppController { return 'I am from the controller.'; } + //@codingStandardsIgnoreStart protected function protected_m() { } @@ -297,6 +298,7 @@ class TestController extends ControllerTestAppController { public function _hidden() { } + //@codingStandardsIgnoreEnd public function admin_add() { } diff --git a/lib/Cake/Test/Case/Network/Email/CakeEmailTest.php b/lib/Cake/Test/Case/Network/Email/CakeEmailTest.php index ba7a65e5c..3d02a30d4 100644 --- a/lib/Cake/Test/Case/Network/Email/CakeEmailTest.php +++ b/lib/Cake/Test/Case/Network/Email/CakeEmailTest.php @@ -1196,7 +1196,7 @@ class CakeEmailTest extends CakeTestCase { $this->assertContains('Content-Type: text/html; charset=UTF-8', $message); // UTF-8 is 8bit - $this->assertTrue($this->checkContentTransferEncoding($message, '8bit')); + $this->assertTrue($this->_checkContentTransferEncoding($message, '8bit')); $this->CakeEmail->charset = 'ISO-2022-JP'; $this->CakeEmail->send(); @@ -1205,7 +1205,7 @@ class CakeEmailTest extends CakeTestCase { $this->assertContains('Content-Type: text/html; charset=ISO-2022-JP', $message); // ISO-2022-JP is 7bit - $this->assertTrue($this->checkContentTransferEncoding($message, '7bit')); + $this->assertTrue($this->_checkContentTransferEncoding($message, '7bit')); } /** @@ -1451,7 +1451,7 @@ class CakeEmailTest extends CakeTestCase { $this->assertContains(mb_convert_encoding('ってテーブルを作ってやってたらう','ISO-2022-JP'), $result['message']); } - private function checkContentTransferEncoding($message, $charset) { + protected function _checkContentTransferEncoding($message, $charset) { $boundary = '--alt-' . $this->CakeEmail->getBoundary(); $result['text'] = false; $result['html'] = false; @@ -1480,6 +1480,7 @@ class CakeEmailTest extends CakeTestCase { /** * Test CakeEmail::_encode function * + * @return void */ public function testEncode() { $this->skipIf(!function_exists('mb_convert_encoding'));