moving order for finds from constructor to beforeFind

This commit is contained in:
Ceeram 2011-11-24 22:12:39 +01:00
parent 2969a8f6ac
commit c12c853f10

View file

@ -29,21 +29,31 @@ class CakeTestModel extends Model {
public $cacheSources = false; public $cacheSources = false;
/** /**
* Constructor, sets default order for the model to avoid failing tests caused by * Sets default order for the model to avoid failing tests caused by
* incorrect order when no order has been defined in the finds. * incorrect order when no order has been defined in the finds.
* Postgres can return the results in any order it considers appropriate if none is specified * Postgres can return the results in any order it considers appropriate if none is specified
* *
* @param mixed $id Set this ID for this model on startup, can also be an array of options, see Model::__construct(). * @param array $queryData
* @param string $table Name of database table to use. * @return array $queryData
* @param string $ds DataSource connection name.
*/ */
function __construct($id = false, $table = null, $ds = null) { public function beforeFind($queryData) {
parent::__construct($id, $table, $ds); $pk = $this->primaryKey;
if ($this->useTable && $this->primaryKey && $this->schema($this->primaryKey)) { $aliasedPk = $this->alias . '.' . $this->primaryKey;
$this->order = array($this->alias . '.' . $this->primaryKey => 'ASC'); switch(true) {
$this->_schema = null; case !$pk:
case !$this->useTable:
case !$this->schema('id'):
case !empty($queryData['order'][0]):
case !empty($queryData['group']):
case
(is_string($queryData['fields']) && !($queryData['fields'] == $pk || $queryData['fields'] == $aliasedPk)) ||
(is_array($queryData['fields']) && !(array_key_exists($pk, $queryData['fields']) || array_key_exists($aliasedPk, $queryData['fields']))):
break;
default:
$queryData['order'] = array($this->alias . '.' . $this->primaryKey => 'ASC');
break;
} }
$this->_sourceConfigured = false; return $queryData;
} }
} }