adulau/cakephp2-php8
1
0
Fork 0
mirror of https://github.com/kamilwylegala/cakephp2-php8.git synced 2025-01-31 09:06:17 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

Altering Helper::url() to enforce escaped query strings for generated urls.

Browse source 
Tests added to Html::link().  Fixes #5982

git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7991 3807eeeb-6ff5-0310-8944-8be069107fe0
This commit is contained in:
mark_story 2009-01-14 22:41:47 +00:00
parent de1d1ae3bd
commit b94a85e938
2 changed files with 11 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
cake/libs/view/helper.php
View file

@ -175,7 +175,7 @@ class Helper extends Overloadable {
* @return string Full translated URL with base path. * @return string Full translated URL with base path.
*/ */
function url($url = null, $full = false) { function url($url = null, $full = false) {
return Router::url($url, $full); return Router::url($url, array('full' => $full, 'escape' => true));
} }
/** /**
* Checks if a file exists when theme is used, if no file is found default location is returned * Checks if a file exists when theme is used, if no file is found default location is returned

10
cake/tests/cases/libs/view/helpers/html.test.php
View file

@ -148,6 +148,16 @@ class HtmlHelperTest extends CakeTestCase {
'/a' '/a'
); );
$this->assertTags($result, $expected); $this->assertTags($result, $expected);
$result = $this->Html->link('Original size', array(
'controller' => 'images', 'action' => 'view', 3, '?' => array('height' => 100, 'width' => 200)
));
$expected = array(
'a' => array('href' => '/images/view/3?height=100&width=200'),
'Original size',
'/a'
);
$this->assertTags($result, $expected);
Configure::write('Asset.timestamp', false); Configure::write('Asset.timestamp', false);