adulau/cakephp2-php8
1
0
Fork 0
mirror of https://github.com/kamilwylegala/cakephp2-php8.git synced 2024-11-15 03:18:26 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

test: Removed pre-checking of tests that were skipped in the PHPUnit version since the minimum version is now 9.5.

Browse source
This commit is contained in:
Koji Tanaka 2022-12-28 18:46:38 +09:00 committed by Kamil Wylegala
parent a1ed2f91b3
commit b1229c9107
2 changed files with 0 additions and 15 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
lib/Cake/Test/Case/Event/CakeEventManagerTest.php
View file

@ -230,10 +230,6 @@ class CakeEventManagerTest extends CakeTestCase {
* @triggers fake.event * @triggers fake.event
*/ */
public function testDispatchReturnValue() { public function testDispatchReturnValue() {
$this->skipIf(
version_compare(PHPUnit_Runner_Version::id(), '3.7', '<'),
'These tests fail in PHPUnit 3.6'
);
$manager = new CakeEventManager(); $manager = new CakeEventManager();
$listener = $this->getMock('CakeEventTestListener'); $listener = $this->getMock('CakeEventTestListener');
$anotherListener = $this->getMock('CakeEventTestListener'); $anotherListener = $this->getMock('CakeEventTestListener');
@ -258,11 +254,6 @@ class CakeEventManagerTest extends CakeTestCase {
* @triggers fake.event * @triggers fake.event
*/ */
public function testDispatchFalseStopsEvent() { public function testDispatchFalseStopsEvent() {
$this->skipIf(
version_compare(PHPUnit_Runner_Version::id(), '3.7', '<'),
'These tests fail in PHPUnit 3.6'
);
$manager = new CakeEventManager(); $manager = new CakeEventManager();
$listener = $this->getMock('CakeEventTestListener'); $listener = $this->getMock('CakeEventTestListener');
$anotherListener = $this->getMock('CakeEventTestListener'); $anotherListener = $this->getMock('CakeEventTestListener');

6
lib/Cake/TestSuite/CakeTestCase.php
View file

@ -761,12 +761,6 @@ abstract class CakeTestCase extends \PHPUnit\Framework\TestCase {
$callOriginalMethods = false, $callOriginalMethods = false,
$proxyTarget = null $proxyTarget = null
) { ) {
$phpUnitVersion = PHPUnit_Runner_Version::id();
if (version_compare($phpUnitVersion, '5.7.0', '<')) {
return parent::getMock($originalClassName, $methods, $arguments,
$mockClassName, $callOriginalConstructor, $callOriginalClone,
$callAutoload, $cloneArguments, $callOriginalMethods, $proxyTarget);
}
if ($cloneArguments) { if ($cloneArguments) {
throw new InvalidArgumentException('$cloneArguments parameter is not supported'); throw new InvalidArgumentException('$cloneArguments parameter is not supported');
} }