adulau/cakephp2-php8
1
0
Fork 0
mirror of https://github.com/kamilwylegala/cakephp2-php8.git synced 2025-01-31 09:06:17 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

making the name lowercase in the addDetector method so that it will be found in the is() method fixes #2622 with tests.

Browse source
This commit is contained in:
dogmatic69 2012-02-28 16:05:24 +00:00
parent 677f0708dc
commit ac06880241
2 changed files with 6 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
lib/Cake/Network/CakeRequest.php
View file

@ -516,6 +516,7 @@ class CakeRequest implements ArrayAccess {
* @return void
*/
public function addDetector($name, $options) {
$name = strtolower($name);
if (isset($this->_detectors[$name]) && isset($options['options'])) {
$options = Set::merge($this->_detectors[$name], $options);
}

5
lib/Cake/Test/Case/Network/CakeRequestTest.php
View file

@ -793,6 +793,11 @@ class CakeRequestTest extends CakeTestCase {
$_SERVER['TEST_VAR'] = 'wrong';
$this->assertFalse($request->is('compare'), 'Value mis-match failed.');
$request->addDetector('compareCamelCase', array('env' => 'TEST_VAR', 'value' => 'foo'));
$_SERVER['TEST_VAR'] = 'foo';
$this->assertTrue($request->is('compareCamelCase'), 'Value match failed.');
$request->addDetector('banana', array('env' => 'TEST_VAR', 'pattern' => '/^ban.*$/'));
$_SERVER['TEST_VAR'] = 'banana';