adulau/cakephp2-php8
1
0
Fork 0
mirror of https://github.com/kamilwylegala/cakephp2-php8.git synced 2025-02-12 06:56:24 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

Fixing issue where fixtures without field definitions would drop tables,

Browse source 
even though they had no way to re-create them. Fixes #1519
This commit is contained in:
mark_story 2011-02-08 21:53:12 -05:00
parent 9a940709ab
commit a5fb2cf8a7
2 changed files with 7 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
cake/tests/cases/libs/cake_test_fixture.test.php
View file

@ -391,6 +391,10 @@ class CakeTestFixtureTest extends CakeTestCase {
$this->criticDb->setReturnValueAt(1, 'execute', false); $this->criticDb->setReturnValueAt(1, 'execute', false);
$return = $Fixture->drop($this->criticDb); $return = $Fixture->drop($this->criticDb);
$this->assertFalse($return); $this->assertFalse($return);
unset($Fixture->fields);
$return = $Fixture->drop($this->criticDb);
$this->assertFalse($return);
} }
/** /**

3
cake/tests/lib/cake_test_fixture.php
View file

@ -153,6 +153,9 @@ class CakeTestFixture extends Object {
* @access public * @access public
*/ */
function drop(&$db) { function drop(&$db) {
if (empty($this->fields)) {
return false;
}
$this->Schema->_build(array($this->table => $this->fields)); $this->Schema->_build(array($this->table => $this->fields));
return ( return (
$db->execute($db->dropSchema($this->Schema), array('log' => false)) !== false $db->execute($db->dropSchema($this->Schema), array('log' => false)) !== false