From a357f30cda92559e54aa189ddf134a544b44b7be Mon Sep 17 00:00:00 2001 From: dho Date: Sat, 26 May 2007 07:22:19 +0000 Subject: [PATCH] Fixing problem with handling "0" in NumberHelper::toReadableSize() (ticket #2654) git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@5195 3807eeeb-6ff5-0310-8944-8be069107fe0 --- cake/libs/view/helpers/number.php | 2 ++ cake/tests/cases/libs/view/helpers/number.test.php | 8 ++++++-- 2 files changed, 8 insertions(+), 2 deletions(-) diff --git a/cake/libs/view/helpers/number.php b/cake/libs/view/helpers/number.php index 5d08e05ea..2a0ce8bc1 100644 --- a/cake/libs/view/helpers/number.php +++ b/cake/libs/view/helpers/number.php @@ -58,6 +58,8 @@ class NumberHelper extends AppHelper { */ function toReadableSize($size) { switch($size) { + case 0: + return '0 Bytes'; case 1: return '1 Byte'; case $size < 1024: diff --git a/cake/tests/cases/libs/view/helpers/number.test.php b/cake/tests/cases/libs/view/helpers/number.test.php index d903d9f65..7dcad55e6 100644 --- a/cake/tests/cases/libs/view/helpers/number.test.php +++ b/cake/tests/cases/libs/view/helpers/number.test.php @@ -69,10 +69,14 @@ class NumberTest extends UnitTestCase { $result = $this->Helper->currency($value, false); $expected = '100,100,100.00'; $this->assertEqual($expected, $result); - - } + function testToReadableSize() { + $result = $this->Helper->toReadableSize(0); + $expected = '0 Bytes'; + $this->assertEqual($expected, $result); + } + function tearDown() { unset($this->Helper); }