adulau/cakephp2-php8
1
0
Fork 0
mirror of https://github.com/kamilwylegala/cakephp2-php8.git synced 2024-11-15 11:28:25 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

Merge pull request #1072 from uzyn/httpresponse-3531

Browse source 
Add OK or Successful HTTP codes 200-206 to HttpResponse::isOK().

Fixes #3531
This commit is contained in:
Mark Story 2013-01-14 17:22:18 -08:00
commit a1035f720e
2 changed files with 28 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
lib/Cake/Network/Http/HttpResponse.php
View file

@ -116,12 +116,12 @@ class HttpResponse implements ArrayAccess {
} }
/** /**
* If return is 200 (OK) * If return is a valid 2xx (OK or Successful)
* *
* @return boolean * @return boolean
*/ */
public function isOk() { public function isOk() {
return $this->code == 200; return in_array($this->code, array(200, 201, 202, 203, 204, 205, 206));
} }
/** /**

28
lib/Cake/Test/Case/Network/Http/HttpResponseTest.php
View file

@ -157,12 +157,36 @@ class HttpResponseTest extends CakeTestCase {
$this->assertFalse($this->HttpResponse->isOk()); $this->assertFalse($this->HttpResponse->isOk());
$this->HttpResponse->code = -1; $this->HttpResponse->code = -1;
$this->assertFalse($this->HttpResponse->isOk()); $this->assertFalse($this->HttpResponse->isOk());
$this->HttpResponse->code = 201;
$this->assertFalse($this->HttpResponse->isOk());
$this->HttpResponse->code = 'what?'; $this->HttpResponse->code = 'what?';
$this->assertFalse($this->HttpResponse->isOk()); $this->assertFalse($this->HttpResponse->isOk());
$this->HttpResponse->code = 200; $this->HttpResponse->code = 200;
$this->assertTrue($this->HttpResponse->isOk()); $this->assertTrue($this->HttpResponse->isOk());
$this->HttpResponse->code = 201;
$this->assertTrue($this->HttpResponse->isOk());
$this->HttpResponse->code = 202;
$this->assertTrue($this->HttpResponse->isOk());
$this->HttpResponse->code = 203;
$this->assertTrue($this->HttpResponse->isOk());
$this->HttpResponse->code = 204;
$this->assertTrue($this->HttpResponse->isOk());
$this->HttpResponse->code = 205;
$this->assertTrue($this->HttpResponse->isOk());
$this->HttpResponse->code = 206;
$this->assertTrue($this->HttpResponse->isOk());
$this->HttpResponse->code = 207;
$this->assertFalse($this->HttpResponse->isOk());
$this->HttpResponse->code = 208;
$this->assertFalse($this->HttpResponse->isOk());
$this->HttpResponse->code = 209;
$this->assertFalse($this->HttpResponse->isOk());
$this->HttpResponse->code = 210;
$this->assertFalse($this->HttpResponse->isOk());
$this->HttpResponse->code = 226;
$this->assertFalse($this->HttpResponse->isOk());
$this->HttpResponse->code = 288;
$this->assertFalse($this->HttpResponse->isOk());
$this->HttpResponse->code = 301;
$this->assertFalse($this->HttpResponse->isOk());
} }
/** /**