adulau/cakephp2-php8
1
0
Fork 0
mirror of https://github.com/kamilwylegala/cakephp2-php8.git synced 2024-11-15 11:28:25 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

Merge pull request #1393 from markstory/constant-time-login

Browse source 
Hash passwords even when users don't exist.
This commit is contained in:
José Lorenzo Rodríguez 2013-07-03 13:49:03 -07:00
commit 9c4775a220
2 changed files with 6 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
lib/Cake/Controller/Component/Auth/BaseAuthenticate.php
View file

@ -83,6 +83,9 @@ abstract class BaseAuthenticate {
* conditions for Model::find('first'). If the $password param is not provided * conditions for Model::find('first'). If the $password param is not provided
* the password field will be present in returned array. * the password field will be present in returned array.
* *
* Input passwords will be hashed even when a user doesn't exist. This
* helps mitigate timing attacks that are attempting to find valid usernames.
*
* @param string|array $username The username/identifier, or an array of find conditions. * @param string|array $username The username/identifier, or an array of find conditions.
* @param string $password The password, only used if $username param is string. * @param string $password The password, only used if $username param is string.
* @return boolean|array Either false on failure, or an array of user data. * @return boolean|array Either false on failure, or an array of user data.
@ -95,9 +98,6 @@ abstract class BaseAuthenticate {
if (is_array($username)) { if (is_array($username)) {
$conditions = $username; $conditions = $username;
} else { } else {
if (!$password) {
return false;
}
$conditions = array( $conditions = array(
$model . '.' . $fields['username'] => $username $model . '.' . $fields['username'] => $username
); );
@ -113,6 +113,7 @@ abstract class BaseAuthenticate {
'contain' => $this->settings['contain'], 'contain' => $this->settings['contain'],
)); ));
if (empty($result[$model])) { if (empty($result[$model])) {
$this->passwordHasher()->hash($password);
return false; return false;
} }

3
lib/Cake/Controller/Component/Auth/DigestAuthenticate.php
View file

@ -86,7 +86,8 @@ class DigestAuthenticate extends BasicAuthenticate {
'realm' => '', 'realm' => '',
'qop' => 'auth', 'qop' => 'auth',
'nonce' => '', 'nonce' => '',
'opaque' => '' 'opaque' => '',
'passwordHasher' => 'Simple',
); );
/** /**