mirror of
https://github.com/kamilwylegala/cakephp2-php8.git
synced 2025-01-31 09:06:17 +00:00
Securing AuthComponent against re-POSTing password data
git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@4455 3807eeeb-6ff5-0310-8944-8be069107fe0
This commit is contained in:
parent
80e503a70f
commit
9bba7b70a2
1 changed files with 5 additions and 12 deletions
|
@ -197,25 +197,21 @@ class AuthComponent extends Object {
|
|||
|
||||
if ($this->_normalizeURL($this->loginAction) == $this->_normalizeURL($url)) {
|
||||
// We're already at the login action
|
||||
|
||||
if (empty($controller->data) || !isset($controller->data[$this->userModel])) {
|
||||
return;
|
||||
}
|
||||
|
||||
$data = array(
|
||||
$this->userModel . '.' . $this->fields['username'] => $controller->data[$this->userModel][$this->fields['username']],
|
||||
$this->userModel . '.' . $this->fields['password'] => $controller->data[$this->userModel][$this->fields['password']]
|
||||
$this->userModel . '.' . $this->fields['username'] => '= ' . $controller->data[$this->userModel][$this->fields['username']],
|
||||
$this->userModel . '.' . $this->fields['password'] => '= ' . $controller->data[$this->userModel][$this->fields['password']]
|
||||
);
|
||||
|
||||
if ($this->login($data)) {
|
||||
$controller->redirect($this->redirect(), null, true);
|
||||
} else {
|
||||
$this->Session->setFlash($this->loginError, 'default', array(), 'Auth.login');
|
||||
unset($controller->data[$this->userModel][$this->fields['password']]);
|
||||
}
|
||||
return;
|
||||
|
||||
} else {
|
||||
|
||||
if (!$this->Session->check($this->sessionKey)) {
|
||||
if (!$this->RequestHandler->isAjax()) {
|
||||
$this->Session->write('Auth.redirect', $url);
|
||||
|
@ -225,11 +221,6 @@ class AuthComponent extends Object {
|
|||
$this->render($this->ajaxLogin, 'ajax');
|
||||
exit();
|
||||
}
|
||||
|
||||
} else {
|
||||
|
||||
$this->UserData = $this->Session->read('Contact');
|
||||
$this->set('UserData', $this->UserData);
|
||||
}
|
||||
}
|
||||
|
||||
|
@ -242,6 +233,7 @@ class AuthComponent extends Object {
|
|||
break;
|
||||
case null:
|
||||
case false:
|
||||
return;
|
||||
break;
|
||||
default:
|
||||
trigger_error(__('Auth::startup() - $type is set to an incorrect value. Should be "actions", "objects", or null.'), E_USER_WARNING);
|
||||
|
@ -275,6 +267,7 @@ class AuthComponent extends Object {
|
|||
}
|
||||
|
||||
if (empty($this->userModel)) {
|
||||
trigger_error(__('Could not find $userModel. Please set AuthComponent::$userModel in beforeFilter().'), E_USER_WARNING);
|
||||
return false;
|
||||
}
|
||||
|
||||
|
|
Loading…
Add table
Reference in a new issue