adulau/cakephp2-php8
1
0
Fork 0
mirror of https://github.com/kamilwylegala/cakephp2-php8.git synced 2024-11-15 03:18:26 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

Fix issue writing to file cache

Browse source 
Reading/writing to the same file cache key multiple times
in a row during a single request would result in failed reads.

Fixes #2114
This commit is contained in:
mark_story 2011-10-18 21:21:05 -04:00
parent d7155d374b
commit 95737d7adf
2 changed files with 18 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
lib/Cake/Cache/Engine/FileEngine.php
View file

@ -128,6 +128,7 @@ class FileEngine extends CacheEngine {
$this->_File->flock(LOCK_EX); $this->_File->flock(LOCK_EX);
} }
$this->_File->rewind();
$success = $this->_File->ftruncate(0) && $this->_File->fwrite($contents) && $this->_File->fflush(); $success = $this->_File->ftruncate(0) && $this->_File->fwrite($contents) && $this->_File->fflush();
if ($this->settings['lock']) { if ($this->settings['lock']) {

17
lib/Cake/Test/Case/Cache/Engine/FileEngineTest.php
View file

@ -97,6 +97,23 @@ class FileEngineTest extends CakeTestCase {
Cache::delete('test', 'file_test'); Cache::delete('test', 'file_test');
} }
/**
* Test read/write on the same cache key. Ensures file handles are re-wound.
*
* @return void
*/
public function testConsecutiveReadWrite() {
Cache::write('rw', 'first write', 'file_test');
$result = Cache::read('rw', 'file_test');
Cache::write('rw', 'second write', 'file_test');
$result2 = Cache::read('rw', 'file_test');
Cache::delete('rw', 'file_test');
$this->assertEquals('first write', $result);
$this->assertEquals('second write', $result2);
}
/** /**
* testExpiry method * testExpiry method
* *