adulau/cakephp2-php8
1
0
Fork 0
mirror of https://github.com/kamilwylegala/cakephp2-php8.git synced 2025-01-19 11:06:15 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

Add stricter validation to TestTask.

Browse source 
Empty classnames, and classnames without the correct type suffix
are no longer accepted.  They did the wrong thing anyways.

Fixes #2267
This commit is contained in:
mark_story 2011-11-16 20:38:31 -05:00
parent 9c5ad71abc
commit 8981f49bd5
1 changed files with 8 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
lib/Cake/Console/Command/Task/TestTask.php
View file

@ -205,13 +205,15 @@ class TestTask extends BakeTask {
$this->out(++$key . '. ' . $option); $this->out(++$key . '. ' . $option);
$keys[] = $key; $keys[] = $key;
} }
while (empty($selection)) {
$selection = $this->in(__d('cake_console', 'Choose an existing class, or enter the name of a class that does not exist')); $selection = $this->in(__d('cake_console', 'Choose an existing class, or enter the name of a class that does not exist'));
if (isset($options[$selection - 1])) { if (is_numeric($selection) && isset($options[$selection - 1])) {
$selection = $options[$selection - 1]; $selection = $options[$selection - 1];
} }
if ($type !== 'Model') { if ($type !== 'Model') {
$selection = substr($selection, 0, $typeLength * - 1); $selection = substr($selection, 0, $typeLength * - 1);
} }
}
return $selection; return $selection;
} }