adulau/cakephp2-php8
1
0
Fork 0
mirror of https://github.com/kamilwylegala/cakephp2-php8.git synced 2024-11-15 11:28:25 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

fixes FileLog doesn't delete on rotation if count(files) is greater 'rotate'

Browse source
This commit is contained in:
Schlaefer 2013-10-06 13:59:52 +02:00
parent 355e2efbc6
commit 83d340a3af
2 changed files with 3 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
lib/Cake/Log/Engine/FileLog.php
View file

@ -206,7 +206,7 @@ class FileLog extends BaseLog {
if ($this->_config['rotate']) { if ($this->_config['rotate']) {
$files = glob($filepath . '.*'); $files = glob($filepath . '.*');
if (count($files) === $this->_config['rotate']) { while (count($files) >= $this->_config['rotate']) {
unlink(array_shift($files)); unlink(array_shift($files));
} }
} }

2
lib/Cake/Test/Case/Log/Engine/FileLogTest.php
View file

@ -117,6 +117,8 @@ class FileLogTest extends CakeTestCase {
$result = file_get_contents($files[1]); $result = file_get_contents($files[1]);
$this->assertRegExp('/Warning: Test warning second/', $result); $this->assertRegExp('/Warning: Test warning second/', $result);
file_put_contents($path . 'error.log.0000000000', "The oldest log file with over 35 bytes.\n");
sleep(1); sleep(1);
clearstatcache(); clearstatcache();
$log->write('warning', 'Test warning fourth'); $log->write('warning', 'Test warning fourth');