adulau/cakephp2-php8
1
0
Fork 0
mirror of https://github.com/kamilwylegala/cakephp2-php8.git synced 2025-02-07 20:46:24 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

Merge pull request #899 from dereuromark/2.3-more-tests

Browse source 
default value null makes more sense. add test cases for false.
This commit is contained in:
Mark Story 2012-10-13 18:28:34 -07:00
commit 7ea3ee466d
3 changed files with 20 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
lib/Cake/Test/Case/BasicsTest.php
View file

@ -825,6 +825,18 @@ EXPECTED;
########## DEBUG ########## ########## DEBUG ##########
'<div>this-is-a-test</div>' '<div>this-is-a-test</div>'
########################### ###########################
EXPECTED;
$expected = sprintf($expected, str_replace(CAKE_CORE_INCLUDE_PATH, '', __FILE__), __LINE__ - 8);
$this->assertEquals($expected, $result);
ob_start();
debug(false, false, false);
$result = ob_get_clean();
$expected = <<<EXPECTED
########## DEBUG ##########
false
###########################
EXPECTED; EXPECTED;
$expected = sprintf($expected, str_replace(CAKE_CORE_INCLUDE_PATH, '', __FILE__), __LINE__ - 8); $expected = sprintf($expected, str_replace(CAKE_CORE_INCLUDE_PATH, '', __FILE__), __LINE__ - 8);
$this->assertEquals($expected, $result); $this->assertEquals($expected, $result);

7
lib/Cake/Test/Case/Utility/DebuggerTest.php
View file

@ -391,6 +391,13 @@ array(
[maximum depth reached] [maximum depth reached]
) )
) )
TEXT;
$this->assertTextEquals($expected, $result);
$data = false;
$result = Debugger::exportVar($data);
$expected = <<<TEXT
false
TEXT; TEXT;
$this->assertTextEquals($expected, $result); $this->assertTextEquals($expected, $result);
} }

2
lib/Cake/basics.php
View file

@ -75,7 +75,7 @@ if (!function_exists('debug')) {
* @link http://book.cakephp.org/2.0/en/development/debugging.html#basic-debugging * @link http://book.cakephp.org/2.0/en/development/debugging.html#basic-debugging
* @link http://book.cakephp.org/2.0/en/core-libraries/global-constants-and-functions.html#debug * @link http://book.cakephp.org/2.0/en/core-libraries/global-constants-and-functions.html#debug
*/ */
function debug($var = false, $showHtml = null, $showFrom = true) { function debug($var, $showHtml = null, $showFrom = true) {
if (Configure::read('debug') > 0) { if (Configure::read('debug') > 0) {
App::uses('Debugger', 'Utility'); App::uses('Debugger', 'Utility');
$file = ''; $file = '';