adulau/cakephp2-php8
1
0
Fork 0
mirror of https://github.com/kamilwylegala/cakephp2-php8.git synced 2024-11-15 03:18:26 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

Make Hash::numeric() accept more numeric things.

Browse source 
Negative numbers and other stringy forms of numbers should be accepted.
The name Hash::numeric implies is_numeric which it now uses.

Fixes #2478
This commit is contained in:
mark_story 2013-12-12 17:41:38 -05:00
parent fc6edf4d9c
commit 79701af501
2 changed files with 4 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
lib/Cake/Test/Case/Utility/HashTest.php
View file

@ -665,6 +665,9 @@ class HashTest extends CakeTestCase {
$data = array('one', 2 => 'two', 3 => 'three', 4 => 'four', 'a' => 'five'); $data = array('one', 2 => 'two', 3 => 'three', 4 => 'four', 'a' => 'five');
$this->assertFalse(Hash::numeric(array_keys($data))); $this->assertFalse(Hash::numeric(array_keys($data)));
$data = array(2.4, 1, 0, -1, -2);
$this->assertTrue(Hash::numeric($data));
} }
/** /**

4
lib/Cake/Utility/Hash.php
View file

@ -626,9 +626,7 @@ class Hash {
if (empty($data)) { if (empty($data)) {
return false; return false;
} }
$values = array_values($data); return $data === array_filter($data, 'is_numeric');
$str = implode('', $values);
return (bool)ctype_digit($str);
} }
/** /**