adulau/cakephp2-php8
1
0
Fork 0
mirror of https://github.com/kamilwylegala/cakephp2-php8.git synced 2024-11-15 03:18:26 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

Merge pull request #5845 from cakephp/issue-5832

Browse source 
Don't create invalid maxlength attributes for decimal columns.
This commit is contained in:
Mark Story 2015-02-06 19:46:24 -05:00
commit 77e8110a1a
2 changed files with 27 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

26
lib/Cake/Test/Case/View/Helper/FormHelperTest.php
View file

@ -763,6 +763,32 @@ class FormHelperTest extends CakeTestCase {
$this->assertTags($result, $expected);
}
/**
* Tests correct generation of decimal fields as text inputs
*
* @return void
*/
public function testTextFieldGenerationForDecimalAsText() {
$this->Form->create('ValidateUser');
$result = $this->Form->input('cost_decimal', array(
'type' => 'text'
));
$expected = array(
'div' => array('class' => 'input text'),
'label' => array('for' => 'ValidateUserCostDecimal'),
'Cost Decimal',
'/label',
array('input' => array(
'type' => 'text',
'name' => 'data[ValidateUser][cost_decimal]',
'id' => 'ValidateUserCostDecimal',
'maxlength' => 6,
)),
'/div'
);
$this->assertTags($result, $expected);
}
/**
* Tests correct generation of number fields for integer fields
*

2
lib/Cake/View/Helper/FormHelper.php
View file

@ -1292,7 +1292,7 @@ class FormHelper extends AppHelper {
if ($autoLength &&
in_array($options['type'], array('text', 'textarea', 'email', 'tel', 'url', 'search'))
) {
$options['maxlength'] = $fieldDef['length'];
$options['maxlength'] = (int)$fieldDef['length'];
}
return $options;
}