adulau/cakephp2-php8
1
0
Fork 0
mirror of https://github.com/kamilwylegala/cakephp2-php8.git synced 2024-11-29 18:27:19 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

Fix directory traversal of .ctp files

Browse source
This commit is contained in:
chinpei215 2016-11-27 18:03:32 +09:00
parent 02df9ff72e
commit 74c2ded872
3 changed files with 26 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
app/Controller/PagesController.php
View file

@ -41,8 +41,9 @@ class PagesController extends AppController {
* Displays a view * Displays a view
* *
* @return void * @return void
* @throws ForbiddenException When a directory traversal attempt.
* @throws NotFoundException When the view file could not be found * @throws NotFoundException When the view file could not be found
* or MissingViewException in debug mode. * or MissingViewException in debug mode.
*/ */
public function display() { public function display() {
$path = func_get_args(); $path = func_get_args();
@ -51,6 +52,9 @@ class PagesController extends AppController {
if (!$count) { if (!$count) {
return $this->redirect('/'); return $this->redirect('/');
} }
if (in_array('..', $path, true) || in_array('.', $path, true)) {
throw new ForbiddenException();
}
$page = $subpage = $title_for_layout = null; $page = $subpage = $title_for_layout = null;
if (!empty($path[0])) { if (!empty($path[0])) {

4
lib/Cake/Console/Templates/skel/Controller/PagesController.php
View file

@ -32,6 +32,7 @@ class PagesController extends AppController {
* Displays a view * Displays a view
* *
* @return void * @return void
* @throws ForbiddenException When a directory traversal attempt.
* @throws NotFoundException When the view file could not be found * @throws NotFoundException When the view file could not be found
* or MissingViewException in debug mode. * or MissingViewException in debug mode.
*/ */
@ -42,6 +43,9 @@ class PagesController extends AppController {
if (!$count) { if (!$count) {
return $this->redirect('/'); return $this->redirect('/');
} }
if (in_array('..', $path, true) || in_array('.', $path, true)) {
throw new ForbiddenException();
}
$page = $subpage = $title_for_layout = null; $page = $subpage = $title_for_layout = null;
if (!empty($path[0])) { if (!empty($path[0])) {

17
lib/Cake/Test/Case/Controller/PagesControllerTest.php
View file

@ -75,4 +75,21 @@ class PagesControllerTest extends CakeTestCase {
$Pages = new PagesController(new CakeRequest(null, false), new CakeResponse()); $Pages = new PagesController(new CakeRequest(null, false), new CakeResponse());
$Pages->display('non_existing_page'); $Pages->display('non_existing_page');
} }
/**
* Test directory traversal protection
*
* @expectedException ForbiddenException
* @expectedExceptionCode 403
* @return void
*/
public function testDirectoryTraversalProtection() {
App::build(array(
'View' => array(
CAKE . 'Test' . DS . 'test_app' . DS . 'View' . DS
)
));
$Pages = new PagesController(new CakeRequest(null, false), new CakeResponse());
$Pages->display('..', 'Posts', 'index');
}
} }