adulau/cakephp2-php8
1
0
Fork 0
mirror of https://github.com/kamilwylegala/cakephp2-php8.git synced 2024-11-15 11:28:25 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

Fixing Accept header parsing so content types with leading/trailing spaces

Browse source 
are treated as spaceless.
Fixes #1684
This commit is contained in:
mark_story 2011-08-25 22:31:25 -04:00
parent ec79a09d27
commit 72ef310867
2 changed files with 5 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
cake/libs/controller/components/request_handler.php
View file

@ -176,6 +176,7 @@ class RequestHandlerComponent extends Object {
*/
function __construct() {
$this->__acceptTypes = explode(',', env('HTTP_ACCEPT'));
$this->__acceptTypes = array_map('trim', $this->__acceptTypes);
foreach ($this->__acceptTypes as $i => $type) {
if (strpos($type, ';')) {

5
cake/tests/cases/libs/controller/components/request_handler.test.php
View file

@ -469,7 +469,10 @@ class RequestHandlerComponentTest extends CakeTestCase {
$this->_init();
$this->assertTrue($this->RequestHandler->isWap());
$_SERVER['HTTP_ACCEPT'] = 'application/rss+xml,text/xml,application/xml,application/xhtml+xml,text/html,text/plain,image/png,*/*';
$_SERVER['HTTP_ACCEPT'] = 'application/rss+xml , text/xml, application/xml,application/xhtml+xml';
$this->_init();
$this->assertFalse($this->RequestHandler->isAtom());
$this->assertTrue($this->RequestHandler->isRSS());
}
/**