adulau/cakephp2-php8
1
0
Fork 0
mirror of https://github.com/kamilwylegala/cakephp2-php8.git synced 2025-01-18 18:46:17 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

Fixing Set::filter() not predictably filtering in a recursive fashion. While a minor change in behavior, more predictable and uniform behavior is worth it.

Browse source 
Fixes #1431
This commit is contained in:
mark_story 2011-01-05 22:48:09 -05:00
parent 5768bfe5c7
commit 6e2ffafe54
2 changed files with 27 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

16
cake/libs/set.php
View file

@ -68,10 +68,22 @@ class Set {
* @static * @static
*/ */
function filter($var, $isArray = false) { function filter($var, $isArray = false) {
if (is_array($var) && (!empty($var) || $isArray)) { foreach ((array)$var as $k => $v) {
return array_filter($var, array('Set', 'filter')); if (!empty($v) && is_array($v)) {
$var[$k] = array_filter($v, array('Set', '_filter'));
}
} }
return array_filter($var, array('Set', '_filter'));
}
/**
* Set::filter callback function
*
* @param array $var Array to filter.
* @return boolean
* @access protected
*/
function _filter($var) {
if ($var === 0 || $var === '0' || !empty($var)) { if ($var === 0 || $var === '0' || !empty($var)) {
return true; return true;
} }

14
cake/tests/cases/libs/set.test.php
View file

@ -88,8 +88,20 @@ class SetTest extends CakeTestCase {
*/ */
function testFilter() { function testFilter() {
$result = Set::filter(array('0', false, true, 0, array('one thing', 'I can tell you', 'is you got to be', false))); $result = Set::filter(array('0', false, true, 0, array('one thing', 'I can tell you', 'is you got to be', false)));
$expected = array('0', 2 => true, 3 => 0, 4 => array('one thing', 'I can tell you', 'is you got to be', false)); $expected = array('0', 2 => true, 3 => 0, 4 => array('one thing', 'I can tell you', 'is you got to be'));
$this->assertIdentical($result, $expected); $this->assertIdentical($result, $expected);
$result = Set::filter(array(1, array(false)));
$expected = array(1);
$this->assertEqual($expected, $result);
$result = Set::filter(array(1, array(false, false)));
$expected = array(1);
$this->assertEqual($expected, $result);
$result = Set::filter(array(1, array('empty', false)));
$expected = array(1, array('empty'));
$this->assertEqual($expected, $result);
} }
/** /**