adulau/cakephp2-php8
1
0
Fork 0
mirror of https://github.com/kamilwylegala/cakephp2-php8.git synced 2024-11-15 03:18:26 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

Fixing error in String::insert where string that contained a question mark were not propperly replaced

Browse source
This commit is contained in:
José Lorenzo Rodríguez 2009-10-13 10:45:17 -04:30 committed by mark_story
parent 24c82e73c1
commit 6dbb8690ad
2 changed files with 8 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
cake/libs/string.php
View file

@ -236,7 +236,7 @@ class String {
); );
} }
if (strpos($str, '?') !== false) { if (strpos($str, '?') !== false && is_numeric(key($data))) {
$offset = 0; $offset = 0;
while (($pos = strpos($str, '?', $offset)) !== false) { while (($pos = strpos($str, '?', $offset)) !== false) {
$val = array_shift($data); $val = array_shift($data);

7
cake/tests/cases/libs/string.test.php
View file

@ -279,6 +279,13 @@ class StringTest extends CakeTestCase {
$expected = array('tagA', '"single tag"', 'tagB'); $expected = array('tagA', '"single tag"', 'tagB');
$this->assertEqual($expected, $result); $this->assertEqual($expected, $result);
} }
function testReplaceWithQuestionMarkInString() {
$string = ':a, :b and :c?';
$expected = '2 and 3?';
$result = String::insert($string, array('b' => 2, 'c' => 3), array('clean' => true));
$this->assertEqual($expected, $result);
}
} }
?> ?>