From 6d6be87f8ffcf1a86b1ebfde434b104d60dc41f7 Mon Sep 17 00:00:00 2001 From: Phally Date: Sat, 20 Jul 2013 16:59:39 +0200 Subject: [PATCH] Replaces deprecated paginate() calls in controller bake templates. Fixes #3895. --- lib/Cake/Console/Command/Task/ControllerTask.php | 7 ++++--- .../Templates/default/actions/controller_actions.ctp | 2 +- .../Case/Console/Command/Task/ControllerTaskTest.php | 10 +++++----- 3 files changed, 10 insertions(+), 9 deletions(-) diff --git a/lib/Cake/Console/Command/Task/ControllerTask.php b/lib/Cake/Console/Command/Task/ControllerTask.php index cd401c487..cb1a76857 100644 --- a/lib/Cake/Console/Command/Task/ControllerTask.php +++ b/lib/Cake/Console/Command/Task/ControllerTask.php @@ -370,10 +370,11 @@ class ControllerTask extends BakeTask { * @return array Components the user wants to use. */ public function doComponents() { - return $this->_doPropertyChoices( - __d('cake_console', "Would you like this controller to use any components?"), + $components = array('Paginator'); + return array_merge($components, $this->_doPropertyChoices( + __d('cake_console', "Would you like this controller to use other components\nbesides PaginatorComponent?"), __d('cake_console', "Please provide a comma separated list of the component names you'd like to use.\nExample: 'Acl, Security, RequestHandler'") - ); + )); } /** diff --git a/lib/Cake/Console/Templates/default/actions/controller_actions.ctp b/lib/Cake/Console/Templates/default/actions/controller_actions.ctp index 02249c1b0..928ec94af 100644 --- a/lib/Cake/Console/Templates/default/actions/controller_actions.ctp +++ b/lib/Cake/Console/Templates/default/actions/controller_actions.ctp @@ -26,7 +26,7 @@ */ public function index() { $this->->recursive = 0; - $this->set('', $this->paginate()); + $this->set('', $this->Paginator->paginate()); } /** diff --git a/lib/Cake/Test/Case/Console/Command/Task/ControllerTaskTest.php b/lib/Cake/Test/Case/Console/Command/Task/ControllerTaskTest.php index 5d85aa569..2047314d6 100644 --- a/lib/Cake/Test/Case/Console/Command/Task/ControllerTaskTest.php +++ b/lib/Cake/Test/Case/Console/Command/Task/ControllerTaskTest.php @@ -224,7 +224,7 @@ class ControllerTaskTest extends CakeTestCase { public function testDoComponentsNo() { $this->Task->expects($this->any())->method('in')->will($this->returnValue('n')); $result = $this->Task->doComponents(); - $this->assertSame(array(), $result); + $this->assertSame(array('Paginator'), $result); } /** @@ -237,7 +237,7 @@ class ControllerTaskTest extends CakeTestCase { $this->Task->expects($this->at(1))->method('in')->will($this->returnValue(' RequestHandler, Security ')); $result = $this->Task->doComponents(); - $expected = array('RequestHandler', 'Security'); + $expected = array('Paginator', 'RequestHandler', 'Security'); $this->assertEquals($expected, $result); } @@ -251,7 +251,7 @@ class ControllerTaskTest extends CakeTestCase { $this->Task->expects($this->at(1))->method('in')->will($this->returnValue(' RequestHandler, Security, , ')); $result = $this->Task->doComponents(); - $expected = array('RequestHandler', 'Security'); + $expected = array('Paginator', 'RequestHandler', 'Security'); $this->assertEquals($expected, $result); } @@ -350,7 +350,7 @@ class ControllerTaskTest extends CakeTestCase { $this->assertContains('function index() {', $result); $this->assertContains('$this->BakeArticle->recursive = 0;', $result); - $this->assertContains("\$this->set('bakeArticles', \$this->paginate());", $result); + $this->assertContains("\$this->set('bakeArticles', \$this->Paginator->paginate());", $result); $this->assertContains('function view($id = null)', $result); $this->assertContains("throw new NotFoundException(__('Invalid bake article'));", $result); @@ -388,7 +388,7 @@ class ControllerTaskTest extends CakeTestCase { $this->assertContains('function index() {', $result); $this->assertContains('$this->BakeArticle->recursive = 0;', $result); - $this->assertContains("\$this->set('bakeArticles', \$this->paginate());", $result); + $this->assertContains("\$this->set('bakeArticles', \$this->Paginator->paginate());", $result); $this->assertContains('function view($id = null)', $result); $this->assertContains("throw new NotFoundException(__('Invalid bake article'));", $result);