From 51d75bc2bec065c5c36c5933f4c9e56ee7cc7373 Mon Sep 17 00:00:00 2001 From: Mark Scherer Date: Wed, 17 Jun 2015 11:04:04 +0200 Subject: [PATCH 1/3] Remove overhead whitespace in templates. --- lib/Cake/View/Helper/HtmlHelper.php | 20 ++++++++++---------- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/lib/Cake/View/Helper/HtmlHelper.php b/lib/Cake/View/Helper/HtmlHelper.php index adb6220d5..68e662c2d 100644 --- a/lib/Cake/View/Helper/HtmlHelper.php +++ b/lib/Cake/View/Helper/HtmlHelper.php @@ -47,13 +47,13 @@ class HtmlHelper extends AppHelper { 'meta' => '', 'metalink' => '', 'link' => '%s', - 'mailto' => '%s', + 'mailto' => '%s', 'form' => '
', 'formend' => '
', 'input' => '', 'textarea' => '', 'hidden' => '', - 'checkbox' => '', + 'checkbox' => '', 'checkboxmultiple' => '', 'radio' => '%s', 'selectstart' => '', - 'file' => '', - 'file_no_model' => '', - 'submit' => '', - 'submitimage' => '', + 'password' => '', + 'file' => '', + 'file_no_model' => '', + 'submit' => '', + 'submitimage' => '', 'button' => '%s', - 'image' => '', + 'image' => '', 'tableheader' => '%s', 'tableheaderrow' => '%s', 'tablecell' => '%s', @@ -91,7 +91,7 @@ class HtmlHelper extends AppHelper { 'fieldsetstart' => '
%s', 'fieldsetend' => '
', 'legend' => '%s', - 'css' => '', + 'css' => '', 'style' => '', 'charset' => '', 'ul' => '%s', @@ -1188,7 +1188,7 @@ class HtmlHelper extends AppHelper { * * ``` * $tags = array( - * 'meta' => '' + * 'meta' => '' * ); * ``` * From 2d7487d33c0a1e0c74d399897803a437c8e056ad Mon Sep 17 00:00:00 2001 From: Mark Scherer Date: Wed, 17 Jun 2015 11:34:03 +0200 Subject: [PATCH 2/3] img tag needs manual space --- lib/Cake/View/Helper/HtmlHelper.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/Cake/View/Helper/HtmlHelper.php b/lib/Cake/View/Helper/HtmlHelper.php index 68e662c2d..2a3e02e55 100644 --- a/lib/Cake/View/Helper/HtmlHelper.php +++ b/lib/Cake/View/Helper/HtmlHelper.php @@ -71,7 +71,7 @@ class HtmlHelper extends AppHelper { 'submit' => '', 'submitimage' => '', 'button' => '%s', - 'image' => '', + 'image' => '', 'tableheader' => '%s', 'tableheaderrow' => '%s', 'tablecell' => '%s', From 7dedf7f86dbc49f667c9db9707f236e243920217 Mon Sep 17 00:00:00 2001 From: Mark Scherer Date: Wed, 17 Jun 2015 11:38:42 +0200 Subject: [PATCH 3/3] Refactor cleanly. --- lib/Cake/View/Helper/HtmlHelper.php | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/Cake/View/Helper/HtmlHelper.php b/lib/Cake/View/Helper/HtmlHelper.php index 2a3e02e55..ae5741136 100644 --- a/lib/Cake/View/Helper/HtmlHelper.php +++ b/lib/Cake/View/Helper/HtmlHelper.php @@ -71,7 +71,7 @@ class HtmlHelper extends AppHelper { 'submit' => '', 'submitimage' => '', 'button' => '%s', - 'image' => '', + 'image' => '', 'tableheader' => '%s', 'tableheaderrow' => '%s', 'tablecell' => '%s', @@ -828,7 +828,7 @@ class HtmlHelper extends AppHelper { unset($options['url']); } - $image = sprintf($this->_tags['image'], $path, $this->_parseAttributes($options, null, '', ' ')); + $image = sprintf($this->_tags['image'], $path, $this->_parseAttributes($options, null, ' ', ' ')); if ($url) { return sprintf($this->_tags['link'], $this->url($url), null, $image);