adulau/cakephp2-php8
1
0
Fork 0
mirror of https://github.com/kamilwylegala/cakephp2-php8.git synced 2024-11-15 03:18:26 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

Potential Fix for LightHouse Ticket #3936

Browse source 
I believe I found a fix for this issue. I am here at #CakeFest2013 and during the #HourOfContribution I ran across this issue.

Currently in CakePHP 2.4 on Line 1522 - 1524 you can see the following code:

@@@ php
if ($label) {
	$optTitle = $this->Html->useTag('label', $tagName, '', $optTitle);
}
@@@

The $label variable here the is the $label array passed into the input method in Sethathi example above. The problem is that the $label array is completely ignored and instead a label is created using the HtmlHelper->useTag method.

I have what I believe is a fix for this issue but it hasn't been extensively tested. I tested against Sethathi example in the ticket and it produced the correct result.

The fix is simple. We detect if an array is passed in and then send it to the FormHelper label method instead of the HtmlHelper useTag method. The FormHelper label methods accepts an options array, so we pass in the $label array.

This will probably need to be fixed for checkbox also

"ask":https://cakephp.lighthouseapp.com/users/235987 helped me with this fix
This commit is contained in:
aread22 2013-09-01 20:56:44 -04:00
parent 5f4feb0729
commit 64bb74a7e8
1 changed files with 6 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
lib/Cake/View/Helper/FormHelper.php
View file

@ -1520,8 +1520,13 @@ class FormHelper extends AppHelper {
);
if ($label) {
$optTitle = $this->Html->useTag('label', $tagName, '', $optTitle);
if(is_array($label)) {
$optTitle = $this->label($tagName, $optTitle, $label);
}else{
$optTitle = $this->Html->useTag('label', $tagName, '', $optTitle);
}
}
if (is_array($between)) {
$optTitle .= array_shift($between);
}