adulau/cakephp2-php8
1
0
Fork 0
mirror of https://github.com/kamilwylegala/cakephp2-php8.git synced 2025-01-19 02:56:15 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

Making unknown errors with codes higher than 500 render as error500.

Browse source 
Test added.
This commit is contained in:
mark_story 2010-12-11 13:30:29 -05:00
parent 504b4d495f
commit 60ada4432a
2 changed files with 19 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
cake/libs/error/exception_renderer.php
View file

@ -107,7 +107,7 @@ class ExceptionRenderer {
} }
} elseif (!$methodExists) { } elseif (!$methodExists) {
$method = 'error500'; $method = 'error500';
if ($code >= 400) { if ($code >= 400 && $code < 500) {
$method = 'error400'; $method = 'error400';
} }
} }

18
cake/tests/cases/libs/error/exception_renderer.test.php
View file

@ -322,6 +322,24 @@ class ExceptionRendererTest extends CakeTestCase {
$this->assertEquals('error500', $ExceptionRenderer->method, 'incorrect method coercion.'); $this->assertEquals('error500', $ExceptionRenderer->method, 'incorrect method coercion.');
} }
/**
* test that unknown exception types with valid status codes are treated correctly.
*
* @return void
*/
function testUnknownExceptionTypeWithCodeHigherThan500() {
$exception = new OutOfBoundsException('foul ball.', 501);
$ExceptionRenderer = new ExceptionRenderer($exception);
$ExceptionRenderer->controller->response = $this->getMock('CakeResponse', array('statusCode', '_sendHeader'));
$ExceptionRenderer->controller->response->expects($this->once())->method('statusCode')->with(501);
ob_start();
$ExceptionRenderer->render();
$results = ob_get_clean();
$this->assertEquals('error500', $ExceptionRenderer->method, 'incorrect method coercion.');
}
/** /**
* testerror400 method * testerror400 method
* *