adulau/cakephp2-php8
1
0
Fork 0
mirror of https://github.com/kamilwylegala/cakephp2-php8.git synced 2024-11-15 03:18:26 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

Fixed deprecation warning when parsing parameters in ShellDispatcher.php

Browse source 
PHP Deprecated:  strpos(): Passing null to parameter #1 ($haystack) of type string is deprecated in lib/Cake/Console/ShellDispatcher.php on line 295

It broke some behat tests for my project because PHP issued warning and then session has not been able to start correctly due to "Session cannot be started after headers have already been sent" error
This commit is contained in:
daris 2023-09-18 13:34:37 +02:00 committed by Kamil Wylegala
parent b0200a75fa
commit 5dbc22efd3
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
lib/Cake/Console/ShellDispatcher.php
View file

@ -292,7 +292,7 @@ class ShellDispatcher {
$params = array_merge($defaults, array_intersect_key($this->params, $defaults)); $params = array_merge($defaults, array_intersect_key($this->params, $defaults));
$isWin = false; $isWin = false;
foreach ($defaults as $default => $value) { foreach ($defaults as $default => $value) {
if (strpos($params[$default], '\\') !== false) { if (!is_null($params[$default]) && strpos($params[$default], '\\') !== false) {
$isWin = true; $isWin = true;
break; break;
} }