adulau/cakephp2-php8
1
0
Fork 0
mirror of https://github.com/kamilwylegala/cakephp2-php8.git synced 2025-02-07 12:36:25 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

Making saveAll() behave like plain save() when suplied empty data array, closes #277

Browse source
This commit is contained in:
José Lorenzo Rodríguez 2010-03-17 15:19:30 -04:30
parent 8375570f8a
commit 5c186d4430
2 changed files with 23 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
cake/libs/model/model.php
View file

@ -1584,6 +1584,11 @@ class Model extends Overloadable {
$validates = true; $validates = true;
$return = array(); $return = array();
if (empty($data) && $options['validate'] !== false) {
$result = $this->save($data, $options);
return !empty($result);
}
if ($options['atomic'] && $options['validate'] !== 'only') { if ($options['atomic'] && $options['validate'] !== 'only') {
$db->begin($this); $db->begin($this);
} }

18
cake/tests/cases/libs/model/model_write.test.php
View file

@ -3798,6 +3798,24 @@ class ModelWriteTest extends BaseModelTest {
$this->assertEqual($resultsFkFalse, $expected); $this->assertEqual($resultsFkFalse, $expected);
} }
/**
* test that saveAll behaves like plain save() when suplied empty data
*
* @link http://cakephp.lighthouseapp.com/projects/42648/tickets/277-test-saveall-with-validation-returns-incorrect-boolean-when-saving-empty-data
* @access public
* @return void
*/
function testSaveAllEmptyData() {
$this->loadFixtures('Article', 'ProductUpdateAll');
$model =& new Article();
$result = $model->saveAll(array(), array('validate' => 'first'));
$this->assertTrue($result);
$model =& new ProductUpdateAll();
$result = $model->saveAll(array());
$this->assertFalse($result);
}
} }
?> ?>