Improve unit test

This commit is contained in:
bancer 2019-03-18 12:43:26 +01:00
parent ec3abd9089
commit 4db38f26ca

View file

@ -34,7 +34,7 @@ class TransSessionIdController extends AppController {
'controller' => 'trans_session_id', 'controller' => 'trans_session_id',
'action' => 'next_step', 'action' => 'next_step',
'?' => array( '?' => array(
htmlspecialchars($sessionName) => htmlspecialchars($sessionId), $sessionName => $sessionId,
), ),
)); ));
} }
@ -78,8 +78,7 @@ class ApplicationControllerTest extends ControllerTestCase {
*/ */
public function testRedirect() { public function testRedirect() {
$sessionId = 'o7k64tlhil9pakp89j6d8ovlqk'; $sessionId = 'o7k64tlhil9pakp89j6d8ovlqk';
CakeSession::id($sessionId); $this->testAction('/trans_session_id/next?CAKEPHP=' . $sessionId);
$this->testAction('/trans_session_id/next');
$this->assertContains('/trans_session_id/next_step?CAKEPHP=' . $sessionId, $this->headers['Location']); $this->assertContains('/trans_session_id/next_step?CAKEPHP=' . $sessionId, $this->headers['Location']);
$expectedConfig = array( $expectedConfig = array(
'cookie' => 'CAKEPHP', 'cookie' => 'CAKEPHP',
@ -100,7 +99,6 @@ class ApplicationControllerTest extends ControllerTestCase {
); );
$actualConfig = Configure::read('Session'); $actualConfig = Configure::read('Session');
$this->assertEquals($expectedConfig, $actualConfig); $this->assertEquals($expectedConfig, $actualConfig);
$this->assertTrue(false, __METHOD__ . ' test has been run');
} }
} }