From 46f8de72a2be00ab10ebbf6536a50b4982f34701 Mon Sep 17 00:00:00 2001 From: mark_story Date: Fri, 13 Jul 2012 22:58:07 -0400 Subject: [PATCH] Fix web runner showing fails as passes when show_passes is on. Fixes #3035 --- lib/Cake/TestSuite/Reporter/CakeBaseReporter.php | 3 +++ 1 file changed, 3 insertions(+) diff --git a/lib/Cake/TestSuite/Reporter/CakeBaseReporter.php b/lib/Cake/TestSuite/Reporter/CakeBaseReporter.php index 6ac39c079..27dfbd790 100644 --- a/lib/Cake/TestSuite/Reporter/CakeBaseReporter.php +++ b/lib/Cake/TestSuite/Reporter/CakeBaseReporter.php @@ -201,6 +201,9 @@ class CakeBaseReporter extends PHPUnit_TextUI_ResultPrinter { */ public function endTest(PHPUnit_Framework_Test $test, $time) { $this->numAssertions += $test->getNumAssertions(); + if ($test->hasFailed()) { + return; + } $this->paintPass($test, $time); }