adulau/cakephp2-php8
1
0
Fork 0
mirror of https://github.com/kamilwylegala/cakephp2-php8.git synced 2024-11-15 03:18:26 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

Merge pull request #971 from ceeram/typehint

Browse source 
Add type hinting to dispatch filters.

This should help provide more helpful errors when developers make mistakes.
This commit is contained in:
Mark Story 2012-11-24 10:09:35 -08:00
commit 4025794b05
3 changed files with 5 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
lib/Cake/Routing/DispatcherFilter.php
View file

@ -66,7 +66,7 @@ abstract class DispatcherFilter implements CakeEventListener {
* keys in the data property.
* @return CakeResponse|boolean
**/
public function beforeDispatch($event) {
public function beforeDispatch(CakeEvent $event) {
}
/**
@ -81,6 +81,6 @@ abstract class DispatcherFilter implements CakeEventListener {
* keys in the data property.
* @return mixed boolean to stop the event dispatching or null to continue
**/
public function afterDispatch($event) {
public function afterDispatch(CakeEvent $event) {
}
}

4
lib/Cake/Routing/Filter/AssetDispatcher.php
View file

@ -40,7 +40,7 @@ class AssetDispatcher extends DispatcherFilter {
* @param CakeEvent $event containing the request and response object
* @return CakeResponse if the client is requesting a recognized asset, null otherwise
*/
public function beforeDispatch($event) {
public function beforeDispatch(CakeEvent $event) {
$url = $event->data['request']->url;
if (strpos($url, '..') !== false || strpos($url, '.') === false) {
return;
@ -77,7 +77,7 @@ class AssetDispatcher extends DispatcherFilter {
* @param CakeEvent $event containing the request and response object
* @return CakeResponse if the client is requesting a recognized asset, null otherwise
*/
protected function _filterAsset($event) {
protected function _filterAsset(CakeEvent $event) {
$url = $event->data['request']->url;
$response = $event->data['response'];
$filters = Configure::read('Asset.filter');

2
lib/Cake/Routing/Filter/CacheDispatcher.php
View file

@ -36,7 +36,7 @@ class CacheDispatcher extends DispatcherFilter {
* @param CakeEvent $event containing the request and response object
* @return CakeResponse with cached content if found, null otherwise
*/
public function beforeDispatch($event) {
public function beforeDispatch(CakeEvent $event) {
if (Configure::read('Cache.check') !== true) {
return;
}