mirror of
https://github.com/kamilwylegala/cakephp2-php8.git
synced 2025-01-18 02:26:17 +00:00
Moving another part of AuthComponent's authorize strategies into BaseAuthorize.
Implementing CrudAuthorize and adding tests for it.
This commit is contained in:
mark_story
parent
7207dccc7c
commit
2e9d9479a6
3 changed files with 245 additions and 0 deletions
|
|
@ -36,6 +36,21 @@ abstract class BaseAuthorize {
|
|||
*/
|
||||
public $actionPath = null;
|
||||
|
||||
/**
|
||||
* Action -> crud mappings. Used by authorization objects that want to map actions to CRUD roles.
|
||||
*
|
||||
* @var array
|
||||
* @see CrudAuthorize
|
||||
*/
|
||||
protected $_actionMap = array(
|
||||
'index' => 'read',
|
||||
'add' => 'create',
|
||||
'edit' => 'update',
|
||||
'view' => 'read',
|
||||
'delete' => 'delete',
|
||||
'remove' => 'delete'
|
||||
);
|
||||
|
||||
/**
|
||||
* Constructor
|
||||
*
|
||||
|
|
@ -87,4 +102,26 @@ abstract class BaseAuthorize {
|
|||
$this->actionPath . $path
|
||||
);
|
||||
}
|
||||
|
||||
/**
|
||||
* Maps crud actions to actual controller names. Used to modify or get the current mapped actions.
|
||||
*
|
||||
* @param mixed $map Either an array of mappings, or undefined to get current values.
|
||||
* @return mixed Either the current mappings or null when setting.
|
||||
*/
|
||||
public function mapActions($map = array()) {
|
||||
if (empty($map)) {
|
||||
return $this->_actionMap;
|
||||
}
|
||||
$crud = array('create', 'read', 'update', 'delete');
|
||||
foreach ($map as $action => $type) {
|
||||
if (in_array($action, $crud) && is_array($type)) {
|
||||
foreach ($type as $typedAction) {
|
||||
$this->_actionMap[$typedAction] = $action;
|
||||
}
|
||||
} else {
|
||||
$this->_actionMap[$action] = $type;
|
||||
}
|
||||
}
|
||||
}
|
||||
}
|
||||
59
cake/libs/controller/components/auth/crud_authorize.php
Normal file
59
cake/libs/controller/components/auth/crud_authorize.php
Normal file
|
|
@ -0,0 +1,59 @@
|
|||
<?php
|
||||
/**
|
||||
* PHP 5
|
||||
*
|
||||
* CakePHP(tm) : Rapid Development Framework (http://cakephp.org)
|
||||
* Copyright 2005-2010, Cake Software Foundation, Inc. (http://cakefoundation.org)
|
||||
*
|
||||
* Licensed under The MIT License
|
||||
* Redistributions of files must retain the above copyright notice.
|
||||
*
|
||||
* @copyright Copyright 2005-2010, Cake Software Foundation, Inc. (http://cakefoundation.org)
|
||||
* @link http://cakephp.org CakePHP(tm) Project
|
||||
* @license MIT License (http://www.opensource.org/licenses/mit-license.php)
|
||||
*/
|
||||
App::import('Component', 'auth/base_authorize');
|
||||
|
||||
/**
|
||||
* An authorization adapter for AuthComponent. Provides the ability to authorize using CRUD mappings.
|
||||
* CRUD mappings allow you to translate controller actions into *C*reate *R*ead *U*pdate *D*elete actions.
|
||||
* This is then checked in the AclComponent as specific permissions.
|
||||
*
|
||||
* For example, taking `/posts/index` as the current request. The default mapping for `index`, is a `read` permission
|
||||
* check. The Acl check would then be for the `posts` controller with the `read` permission. This allows you
|
||||
* to create permission systems that focus more on what is being done to resources, rather than the specific actions
|
||||
* being visited.
|
||||
*
|
||||
* @package cake.libs.controller.components.auth
|
||||
* @since 2.0
|
||||
* @see AuthComponent::$authenticate
|
||||
* @see AclComponent::check()
|
||||
*/
|
||||
class CrudAuthorize extends BaseAuthorize {
|
||||
|
||||
/**
|
||||
* Authorize a user using the mapped actions and the AclComponent.
|
||||
*
|
||||
* @param array $user The user to authorize
|
||||
* @param CakeRequest $request The request needing authorization.
|
||||
* @return boolean
|
||||
*/
|
||||
public function authorize($user, CakeRequest $request) {
|
||||
if (!isset($this->_actionMap[$request->params['action']])) {
|
||||
trigger_error(__(
|
||||
'CrudAuthorize::authorize() - Attempted access of un-mapped action "%1$s" in controller "%2$s"',
|
||||
$request->action,
|
||||
$request->controller
|
||||
),
|
||||
E_USER_WARNING
|
||||
);
|
||||
return false;
|
||||
}
|
||||
$Acl = $this->_controller->Components->load('Acl');
|
||||
return $Acl->check(
|
||||
$user,
|
||||
$this->action($request, ':controller'),
|
||||
$this->_actionMap[$request->params['action']]
|
||||
);
|
||||
}
|
||||
}
|
||||
|
|
@ -0,0 +1,149 @@
|
|||
<?php
|
||||
|
||||
App::import('Component', 'auth/crud_authorize');
|
||||
App::import('Controller', 'ComponentCollection');
|
||||
App::import('Component', 'Acl');
|
||||
App::import('Core', 'CakeRequest');
|
||||
App::import('Core', 'Controller');
|
||||
|
||||
class ActionsAuthorizeTest extends CakeTestCase {
|
||||
|
||||
/**
|
||||
* setup
|
||||
*
|
||||
* @return void
|
||||
*/
|
||||
function setUp() {
|
||||
parent::setUp();
|
||||
$this->controller = $this->getMock('Controller', array(), array(), '', false);
|
||||
$this->Acl = $this->getMock('AclComponent', array(), array(), '', false);
|
||||
$this->controller->Components = $this->getMock('ComponentCollection');
|
||||
|
||||
$this->auth = new CrudAuthorize($this->controller);
|
||||
}
|
||||
|
||||
/**
|
||||
* setup the mock acl.
|
||||
*
|
||||
* @return void
|
||||
*/
|
||||
protected function _mockAcl() {
|
||||
$this->controller->Components->expects($this->any())
|
||||
->method('load')
|
||||
->with('Acl')
|
||||
->will($this->returnValue($this->Acl));
|
||||
}
|
||||
|
||||
/**
|
||||
* test authorize() without a mapped action, ensure an error is generated.
|
||||
*
|
||||
* @expectedException Exception
|
||||
* @return void
|
||||
*/
|
||||
function testAuthorizeNoMappedAction() {
|
||||
$request = new CakeRequest('/posts/foobar', false);
|
||||
$request->addParams(array(
|
||||
'controller' => 'posts',
|
||||
'action' => 'foobar'
|
||||
));
|
||||
$user = array('User' => array('user' => 'mark'));
|
||||
|
||||
$this->auth->authorize($user, $request);
|
||||
}
|
||||
|
||||
/**
|
||||
* test check() passing
|
||||
*
|
||||
* @return void
|
||||
*/
|
||||
function testAuthorizeCheckSuccess() {
|
||||
$request = new CakeRequest('posts/index', false);
|
||||
$request->addParams(array(
|
||||
'controller' => 'posts',
|
||||
'action' => 'index'
|
||||
));
|
||||
$user = array('User' => array('user' => 'mark'));
|
||||
|
||||
$this->_mockAcl();
|
||||
$this->Acl->expects($this->once())
|
||||
->method('check')
|
||||
->with($user, 'Posts', 'read')
|
||||
->will($this->returnValue(true));
|
||||
|
||||
$this->assertTrue($this->auth->authorize($user, $request));
|
||||
}
|
||||
|
||||
/**
|
||||
* test check() failing
|
||||
*
|
||||
* @return void
|
||||
*/
|
||||
function testAuthorizeCheckFailure() {
|
||||
$request = new CakeRequest('posts/index', false);
|
||||
$request->addParams(array(
|
||||
'controller' => 'posts',
|
||||
'action' => 'index'
|
||||
));
|
||||
$user = array('User' => array('user' => 'mark'));
|
||||
|
||||
$this->_mockAcl();
|
||||
$this->Acl->expects($this->once())
|
||||
->method('check')
|
||||
->with($user, 'Posts', 'read')
|
||||
->will($this->returnValue(false));
|
||||
|
||||
$this->assertFalse($this->auth->authorize($user, $request));
|
||||
}
|
||||
|
||||
|
||||
/**
|
||||
* test getting actionMap
|
||||
*
|
||||
* @return void
|
||||
*/
|
||||
function testMapActionsGet() {
|
||||
$result = $this->auth->mapActions();
|
||||
$expected = array(
|
||||
'index' => 'read',
|
||||
'add' => 'create',
|
||||
'edit' => 'update',
|
||||
'view' => 'read',
|
||||
'delete' => 'delete',
|
||||
'remove' => 'delete'
|
||||
);
|
||||
$this->assertEquals($expected, $result);
|
||||
}
|
||||
|
||||
/**
|
||||
* test adding into mapActions
|
||||
*
|
||||
* @return void
|
||||
*/
|
||||
function testMapActionsSet() {
|
||||
$map = array(
|
||||
'create' => array('generate'),
|
||||
'read' => array('listing', 'show'),
|
||||
'update' => array('update'),
|
||||
'random' => 'custom'
|
||||
);
|
||||
$result = $this->auth->mapActions($map);
|
||||
$this->assertNull($result);
|
||||
|
||||
$result = $this->auth->mapActions();
|
||||
$expected = array(
|
||||
'index' => 'read',
|
||||
'add' => 'create',
|
||||
'edit' => 'update',
|
||||
'view' => 'read',
|
||||
'delete' => 'delete',
|
||||
'remove' => 'delete',
|
||||
'generate' => 'create',
|
||||
'listing' => 'read',
|
||||
'show' => 'read',
|
||||
'update' => 'update',
|
||||
'random' => 'custom'
|
||||
);
|
||||
$this->assertEquals($expected, $result);
|
||||
}
|
||||
|
||||
}
|
||||
Loading…
Add table
Reference in a new issue