From 2c70319d2721e09cfd8ad3aae34d0aa26f95a136 Mon Sep 17 00:00:00 2001
From: dogmatic69 <dogmatic69@gmail.com>
Date: Fri, 14 Sep 2012 01:50:24 +0100
Subject: [PATCH] Cleaning up the AuthComponent

Simplify if statements, return early and less variable use
---
 .../Controller/Component/AuthComponent.php    | 68 ++++++++++---------
 1 file changed, 35 insertions(+), 33 deletions(-)

diff --git a/lib/Cake/Controller/Component/AuthComponent.php b/lib/Cake/Controller/Component/AuthComponent.php
index e9e01b611..f0b824f3e 100644
--- a/lib/Cake/Controller/Component/AuthComponent.php
+++ b/lib/Cake/Controller/Component/AuthComponent.php
@@ -300,23 +300,24 @@ class AuthComponent extends Component {
 				}
 			}
 			return true;
-		} else {
-			if (!$this->_getUser()) {
-				if (!$request->is('ajax')) {
-					$this->flash($this->authError);
-					$this->Session->write('Auth.redirect', $request->here());
-					$controller->redirect($loginAction);
-					return false;
-				} elseif (!empty($this->ajaxLogin)) {
-					$controller->viewPath = 'Elements';
-					echo $controller->render($this->ajaxLogin, $this->RequestHandler->ajaxLayout);
-					$this->_stop();
-					return false;
-				} else {
-					$controller->redirect(null, 403);
-				}
-			}
 		}
+
+		if (!$this->_getUser()) {
+			if (!$request->is('ajax')) {
+				$this->flash($this->authError);
+				$this->Session->write('Auth.redirect', $request->here());
+				$controller->redirect($loginAction);
+				return false;
+			}
+			if (!empty($this->ajaxLogin)) {
+				$controller->viewPath = 'Elements';
+				echo $controller->render($this->ajaxLogin, $this->RequestHandler->ajaxLayout);
+				$this->_stop();
+				return false;
+			}
+			$controller->redirect(null, 403);
+		}
+
 		if (empty($this->authorize) || $this->isAuthorized($this->user())) {
 			return true;
 		}
@@ -360,7 +361,8 @@ class AuthComponent extends Component {
 	public function isAuthorized($user = null, $request = null) {
 		if (empty($user) && !$this->user()) {
 			return false;
-		} elseif (empty($user)) {
+		}
+		if (empty($user)) {
 			$user = $this->user();
 		}
 		if (empty($request)) {
@@ -428,12 +430,12 @@ class AuthComponent extends Component {
 		$args = func_get_args();
 		if (empty($args) || $action === null) {
 			$this->allowedActions = $this->_methods;
-		} else {
-			if (isset($args[0]) && is_array($args[0])) {
-				$args = $args[0];
-			}
-			$this->allowedActions = array_merge($this->allowedActions, $args);
+			return;
 		}
+		if (isset($args[0]) && is_array($args[0])) {
+			$args = $args[0];
+		}
+		$this->allowedActions = array_merge($this->allowedActions, $args);
 	}
 
 /**
@@ -454,18 +456,18 @@ class AuthComponent extends Component {
 		$args = func_get_args();
 		if (empty($args) || $action === null) {
 			$this->allowedActions = array();
-		} else {
-			if (isset($args[0]) && is_array($args[0])) {
-				$args = $args[0];
-			}
-			foreach ($args as $arg) {
-				$i = array_search($arg, $this->allowedActions);
-				if (is_int($i)) {
-					unset($this->allowedActions[$i]);
-				}
-			}
-			$this->allowedActions = array_values($this->allowedActions);
+			return;
 		}
+		if (isset($args[0]) && is_array($args[0])) {
+			$args = $args[0];
+		}
+		foreach ($args as $arg) {
+			$i = array_search($arg, $this->allowedActions);
+			if (is_int($i)) {
+				unset($this->allowedActions[$i]);
+			}
+		}
+		$this->allowedActions = array_values($this->allowedActions);
 	}
 
 /**