adulau/cakephp2-php8
1
0
Fork 0
mirror of https://github.com/kamilwylegala/cakephp2-php8.git synced 2024-11-15 11:28:25 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

Fixing issue where exceptions for missing required arguments would be raised when trying to get help.

Browse source
This commit is contained in:
mark_story 2010-10-11 22:53:23 -04:00
parent 43646b9372
commit 2af684cbec
2 changed files with 15 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
cake/console/console_option_parser.php
View file

@ -436,7 +436,7 @@ class ConsoleOptionParser {
}
}
foreach ($this->_args as $i => $arg) {
if ($arg->isRequired() && !isset($args[$i])) {
if ($arg->isRequired() && !isset($args[$i]) && empty($params['help'])) {
throw new RuntimeException(
sprintf(__('Missing required arguments. %s is required.'), $arg->name())
);

14
cake/tests/cases/console/console_option_parser.test.php
View file

@ -396,6 +396,20 @@ TEXT;
$this->assertEquals($expected, $result, 'Help does not match');
}
/**
* test that no exception is triggered when help is being generated
*
* @return void
*/
function testHelpNoExceptionWhenGettingHelp() {
$parser = new ConsoleOptionParser('mycommand', false);
$parser->addOption('test', array('help' => 'A test option.'))
->addArgument('model', array('help' => 'The model to make.', 'required' => true));
$result = $parser->parse(array('--help'));
$this->assertTrue($result[0]['help']);
}
/**
* test help() with options and arguments that have choices.
*