adulau/cakephp2-php8
1
0
Fork 0
mirror of https://github.com/kamilwylegala/cakephp2-php8.git synced 2024-11-15 03:18:26 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

Making sure components in controller test cases always have a fresh reference to the request object, fixes #2705

Browse source
This commit is contained in:
Jose Lorenzo Rodriguez 2012-03-24 14:34:29 -04:30
parent 83ceef045d
commit 16bde9c723
3 changed files with 20 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

15
lib/Cake/Test/Case/TestSuite/ControllerTestCaseTest.php
View file

@ -527,4 +527,19 @@ class ControllerTestCaseTest extends CakeTestCase {
$this->Case->testAction('/tests_apps/redirect_to', $options);
}
/**
* Tests that Components storing response or request objects internally during construct
* will always have a fresh reference to those object available
*
* @return void
* @see http://cakephp.lighthouseapp.com/projects/42648-cakephp/tickets/2705-requesthandler-weird-behavior
*/
public function testComponentsSameRequestAndResponse() {
$this->Case->generate('TestsApps');
$options = array('method' => 'get');
$this->Case->testAction('/tests_apps/index', $options);
$this->assertSame($this->Case->controller->response, $this->Case->controller->RequestHandler->response);
$this->assertSame($this->Case->controller->request, $this->Case->controller->RequestHandler->request);
}
}

2
lib/Cake/Test/test_app/Controller/TestsAppsController.php
View file

@ -22,6 +22,8 @@ class TestsAppsController extends AppController {
public $uses = array();
public $components = array('RequestHandler');
public function index() {
$var = '';
if (isset($this->request->query['var'])) {

6
lib/Cake/TestSuite/ControllerTestCase.php
View file

@ -62,9 +62,9 @@ class ControllerTestDispatcher extends Dispatcher {
if (isset($object->response)) {
$object->response = $response;
}
}
if (isset($object->request)) {
$object->request = $request;
if (isset($object->request)) {
$object->request = $request;
}
}
return $this->testController;
}