adulau/cakephp2-php8
1
0
Fork 0
mirror of https://github.com/kamilwylegala/cakephp2-php8.git synced 2025-01-31 09:06:17 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

Fix a problem of tag values which is not taken into account

Browse source 
(when equal to zero) when passing an array to XML object.
This commit is contained in:
Aymeric Derbois 2013-06-09 00:48:59 +02:00
parent e527eab5aa
commit 0cfdb87cdf
2 changed files with 14 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

13
lib/Cake/Test/Case/Utility/XmlTest.php
View file

@ -375,6 +375,19 @@ XML;
$obj = Xml::fromArray($xml, 'attributes'); $obj = Xml::fromArray($xml, 'attributes');
$xmlText = '<' . '?xml version="1.0" encoding="UTF-8"?><tags><tag id="1">defect</tag></tags>'; $xmlText = '<' . '?xml version="1.0" encoding="UTF-8"?><tags><tag id="1">defect</tag></tags>';
$this->assertXmlStringEqualsXmlString($xmlText, $obj->asXML()); $this->assertXmlStringEqualsXmlString($xmlText, $obj->asXML());
$xml = array(
'tag' => array(
'@' => 0,
'@test' => 'A test'
)
);
$obj = Xml::fromArray($xml);
$xmlText = <<<XML
<?xml version="1.0" encoding="UTF-8"?>
<tag test="A test">0</tag>
XML;
$this->assertXmlStringEqualsXmlString($xmlText, $obj->asXML());
} }
/** /**

2
lib/Cake/Utility/Xml.php
View file

@ -310,7 +310,7 @@ class Xml {
} }
$child = $dom->createElement($key); $child = $dom->createElement($key);
if ($childValue) { if (!is_null($childValue)) {
$child->appendChild($dom->createTextNode($childValue)); $child->appendChild($dom->createTextNode($childValue));
} }
if ($childNS) { if ($childNS) {