From 318a557c560705ad5f9cf77b66fa885a6417ef14 Mon Sep 17 00:00:00 2001
From: Mokaddem <mokaddem.sami@gmail.com>
Date: Tue, 25 Apr 2017 09:32:05 +0200
Subject: [PATCH] Added possibility to keep a backup of the old config + check
 if config is valid before starting scripts.

---
 bin/LAUNCH.sh      | 18 +++++++++++++++++-
 bin/Update-conf.py | 20 ++++++++++++++++----
 2 files changed, 33 insertions(+), 5 deletions(-)

diff --git a/bin/LAUNCH.sh b/bin/LAUNCH.sh
index 3e8814c0..af44e794 100755
--- a/bin/LAUNCH.sh
+++ b/bin/LAUNCH.sh
@@ -112,9 +112,17 @@ function launching_queues {
 }
 
 function launching_scripts {
+    echo -e "\t* Checking configuration"
+    bash -c "./Update-conf.py"
+    exitStatus=$?
+    if [ $exitStatus -ge 1 ]; then
+        echo -e $RED"\t* Configuration not up-to-date"$DEFAULT
+        exit
+    fi
+    echo -e $GREEN"\t* Configuration up-to-date"$DEFAULT
+
     screen -dmS "Script"
     sleep 0.1
-
     echo -e $GREEN"\t* Launching ZMQ scripts"$DEFAULT
 
     screen -S "Script" -X screen -t "ModuleInformation" bash -c './ModulesInformationV2.py -k 0 -c 1; read x'
@@ -253,7 +261,15 @@ for i in ${!options[@]}; do
                 bash -c "./Shutdown.py"
                 ;;
             Update-config)
+                echo -e "\t* Checking configuration"
                 bash -c "./Update-conf.py"
+                exitStatus=$?
+                if [ $exitStatus -ge 1 ]; then
+                    echo -e $RED"\t* Configuration not up-to-date"$DEFAULT
+                    exit
+                else
+                    echo -e $GREEN"\t* Configuration up-to-date"$DEFAULT
+                fi
                 ;;
         esac
     fi
diff --git a/bin/Update-conf.py b/bin/Update-conf.py
index 7ceada75..863ff436 100755
--- a/bin/Update-conf.py
+++ b/bin/Update-conf.py
@@ -5,11 +5,15 @@ import ConfigParser
 from ConfigParser import ConfigParser as cfgP
 import os
 from collections import OrderedDict
+import sys
+import shutil
 
 
+#return true if the configuration is up-to-date
 def main():
 
     configfile = os.path.join(os.environ['AIL_BIN'], 'packages/config.cfg')
+    configfileBackup = os.path.join(os.environ['AIL_BIN'], 'packages/config.cfg') + '.backup'
     if not os.path.exists(configfile):
         raise Exception('Unable to find the configuration file. \
                         Did you set environment variables? \
@@ -45,8 +49,8 @@ def main():
                 dicoMissingItem[sec] = list_items
 
     if len(missingSection) == 0 and len(missingItem) == 0:
-        print("Configuration up-to-date")
-        return
+        #print("Configuration up-to-date")
+        return True
     print("/!\\ Configuration not complete. Missing following configuration: /!\\")
     print("+--------------------------------------------------------------------+")
     for section in missingSection:
@@ -62,8 +66,12 @@ def main():
     resp = raw_input("Do you want to auto fix it? [y/n] ")
 
     if resp != 'y':
-        return
+        return False
     else:
+        resp2 = raw_input("Do you want to keep a backup of the old configuration file? [y/n] ")
+        if resp2 == 'y':
+            shutil.move(configfile, configfileBackup)
+
         #Do not keep item ordering in section. New items appened
         for section in missingItem:
             for item, value in dicoMissingItem[section]:
@@ -75,6 +83,7 @@ def main():
 
         with open(configfile, 'w') as f:
             cfg.write(f)
+        return True
 
 
 ''' Return a new dico with the section ordered as the old configuration with the updated one added '''
@@ -96,5 +105,8 @@ def add_items_to_correct_position(sample_dico, old_dico, missingSection, dicoMis
 
 
 if __name__ == "__main__":
-    main()
+    if main():
+        sys.exit()
+    else:
+        sys.exit(1)